Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8287109: Distrust.java failed with CertificateExpiredException #217

Closed
wants to merge 1 commit into from
Closed

8287109: Distrust.java failed with CertificateExpiredException #217

wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jun 8, 2022 •
edited by openjdk bot

Backporting to be on par with all major releases. There is a difference from the original fix: the test is not removed from ProblemList because it is not there at the moment.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287109: Distrust.java failed with CertificateExpiredException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/217/head:pull/217
$ git checkout pull/217

Update a local copy of the PR:
$ git checkout pull/217
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/217/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 217

View PR using the GUI difftool:
$ git pr show -t 217

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/217.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 8, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5b7d066ca5cb68e07a704d3ce13283761c1cf3ad 8287109: Distrust.java failed with CertificateExpiredException Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022 •
edited

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287109: Distrust.java failed with CertificateExpiredException

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Jun 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

Going to push as commit 08e93a9.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 9, 2022
@openjdk openjdk bot closed this Jun 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@yan-too Pushed as commit 08e93a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8287109 branch June 9, 2022 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bae bae bae approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
2 participants
@yan-too @bae